Skip to content

Jwoo/release1.2 - #3608

Merged
jwoo-msft merged 2 commits into
release/1.2from
jwoo/release1.2
Nov 13, 2019
Merged

Jwoo/release1.2#3608
jwoo-msft merged 2 commits into
release/1.2from
jwoo/release1.2

Conversation

@jwoo-msft

@jwoo-msft jwoo-msft commented Nov 13, 2019

Copy link
Copy Markdown
Member

Merging fix for #3552 to release 1.2 branch

Microsoft Reviewers: Open in CodeFlow

@shalinijoshi19 shalinijoshi19 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt look to be the right branch. I think the branch you want is release/1.2

@jwoo-msft
jwoo-msft changed the base branch from 1.2 to release/1.2 November 13, 2019 19:03
@ghost ghost removed the Needs: Author Feedback label Nov 13, 2019
@shalinijoshi19

Copy link
Copy Markdown

@paulcam206 should we just delete some of the stale branches including 1.2 (stale and not used for 1.2 patch fixes)

@shalinijoshi19

Copy link
Copy Markdown

@paulcam206 let's also create an issue maybe for the sharedmodel-ci failure to track this in the PR's as we force-merge them using admin privileges :)

@paulcam206

Copy link
Copy Markdown
Member

@paulcam206 let's also create an issue maybe for the sharedmodel-ci failure to track this in the PR's as we force-merge them using admin privileges :)

#3609

@shalinijoshi19

Copy link
Copy Markdown

@nesalang go ahead and merge these over unless @paulcam206 would like to do a quick check and sign off :)

@jwoo-msft
jwoo-msft merged commit 0b62034 into release/1.2 Nov 13, 2019
@jwoo-msft
jwoo-msft deleted the jwoo/release1.2 branch November 13, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants