Skip to content

Fix homepage videos in Safari #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthidinger merged 3 commits into from
Oct 1, 2019
Merged

Fix homepage videos in Safari #3499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae81ed4
fixing homepage videos in Safari
matthidinger Oct 1, 2019
7e5ce98
change video source markup
matthidinger Oct 1, 2019
76ae10b
Merge branch 'master' into mahiding/sitev2
paulcam206 Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions source/nodejs/adaptivecards-site/themes/adaptivecards/layout/_partial/home-section.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
<a href="<%- learnMoreLink %>"><%- learnMoreTitle %> <i class="fas fa-chevron-right"></i></a>
</div>
<div class="w3-container w3-cell w3-mobile section-video" >
<video data-autoplay="true" muted style="width: 100%; margin-bottom: -8px" data-loop-delay="<%= typeof videoLoopDelay !== 'undefined' ? videoLoopDelay : '' %>"
src="<%- video %>"></video>
<video data-autoplay="true" playsinline muted style="width: 100%; margin-bottom: -8px" data-loop-delay="<%= typeof videoLoopDelay !== 'undefined' ? videoLoopDelay : '' %>">
<source src="<%- video %>" type="video/mp4" />
</video>
</div>
</div>
2 changes: 1 addition & 1 deletion source/nodejs/adaptivecards-site/themes/adaptivecards/layout/index.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

<div class="w3-col l9">
<div class="w3-card" style="background-color: #0078D7">
<video id="vid" autoplay muted style="width: 100%; margin-bottom: -8px"
<video id="vid" playsinline autoplay muted style="width: 100%; margin-bottom: -8px"
data-loop-delay="5000"
src="https://adaptivecardsblob.blob.core.windows.net/assets/AdaptiveIntroVideo.mp4"></video>
</div>
Expand Down