Skip to content

Conversation

@HederGit
Copy link

@HederGit HederGit commented Apr 3, 2025

The Auto Acc funtionality sometimes create inconsistencies in the database when an alternative currency is used. To avoid this the code is updated with a validate to also set the GenJnlLine.Source Currency Amount.

Work Item(s)

Inconsistencies when posting Auto Acc and Alternative Currency

Fixes AB#573902

@HederGit HederGit requested a review from a team as a code owner April 3, 2025 08:51
@HederGit HederGit requested a review from jonasblunck April 3, 2025 08:51
@JesperSchulz
Copy link
Contributor

In order to process this pull request, we would need two things:

  1. A GitHub issue which explains the issue, incl. repro steps. Based on that issue, the product group will determine if this is a suitable candidate to be fixed through a code contribution here on GitHub.
  2. Once the issue is approved, a PR can be created (you jumped the gun there a bit 😉). The changes should incl. a test which demonstrates how the previous issue now has been addressed.

@JesperSchulz JesperSchulz added the follow up Follow up is needed label Apr 3, 2025
@BrightComChristian
Copy link

Hi,
We've tried to reproduce this in CRONUS but it's hard unfortunately. There is a lot of sales order lines like 200+ and each with some auto accounts. This customer has been onprem first on BC17 and now on BC19. We've solved it by creating a new base version.
Maybe we could show you in the testmigration? I think the code is similar to the code in cu12 where there is a rounding but that's missing in this case.

@JesperSchulz
Copy link
Contributor

OK, we need a subject matter expert to look at this code then, as I cannot assess the validity of this code without repro or test cases.
@PredragMaricic, any chance you could look at this PR?

@JesperSchulz JesperSchulz added the SCM GitHub request for SCM area label Apr 9, 2025
@JesperSchulz JesperSchulz added linked Issue is linked to a Azure Boards work item SCM GitHub request for SCM area and removed SCM GitHub request for SCM area follow up Follow up is needed labels Apr 9, 2025
@microsoft microsoft deleted a comment from github-actions bot Apr 9, 2025
@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

@JesperSchulz JesperSchulz enabled auto-merge (squash) April 10, 2025 07:32
@microsoft microsoft deleted a comment from github-actions bot Apr 10, 2025
@github-actions
Copy link
Contributor

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@JesperSchulz JesperSchulz added the ships-in-future-update Fix ships in a future update label Apr 10, 2025
@JesperSchulz
Copy link
Contributor

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 32905.

auto-merge was automatically disabled April 10, 2025 07:36

Pull request was closed

tuan-nguyen-fenwick pushed a commit to tuan-nguyen-fenwick/ALAppExtensions that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed SCM GitHub request for SCM area ships-in-future-update Fix ships in a future update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants