[Event Request] codeunit 7324 "Whse.-Activity-Post" - procedure ConsumeWarehouseEntryForJobPurchase() on BC26

[DennyHW]

Why do you need this change?

One of our apps don't write the negative adjustment on the item ledger entries / warehouse entries for the purchase receipts with the project code indicated.

Please see: #28418

Describe the request

On BC26 I would need a new event in function ConsumeWarehouseEntryForJobPurchase in codeunit 7324 "Whse.-Activity-Post", the same as what you did in codeunit 123456 codeunit 5760 Whse.-Post Receipt (see #28418).
The event should be placed at the beginning of the function (for example onBeforeConsumeWarehouseEntryForJobPurchase) and as parameters it should have the same parameter of the procedure and the IsHandled variable
Exited from the event, if IsHandled = true it must exit the function

for example :
onBeforeConsumeWarehouseEntryForJobPurchase(TempWarehouseJournalLine, PostedWhseReceiptLine, IsHandled)
if IsHandled then
exit(false);

Thanks.
Internal work item: AB#610217

[AleksandricMarko]

Hello @DennyHW

Recently we announced that for every new IsHandled event request, author need to provide a response to several question (please check link)

We want to be sure that IsHandled event is the only option, as this kind of events is not the best approach due to several reasons (codebase harder to maintain, harder refactoring, fragile solutions, easily break other implementations...)

Please also check the explanation about when and how to use IsHandled events (link)

[DennyHW]

As requested by many customers, we developed a feature in the app to prevent negative adjustments to item ledger entries when purchase receipts with a project code are posted.

It’s the same reason described by another partner who opened this extensibility request. #28418

Same use case, same reason, same procedure name, same extensibility request.

Please compare the procedure ConsumeWarehouseEntryForJobPurchase in codeunit 7324 "Whse.-Activity-Post", the same as what you did in codeunit 123456 codeunit 5760 Whse.-Post Receipt.

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Add a new integration event OnBeforeConsumeWarehouseEntryForJobPurchase at the beginning of the ConsumeWarehouseEntryForJobPurchase procedure in Codeunit 7324 "Whse.-Activity-Post".

In procedure ConsumeWarehouseEntryForJobPurchase (after parameter declarations, before the business logic checks):

local procedure ConsumeWarehouseEntryForJobPurchase(var TempWarehouseJournalLine: Record "Warehouse Journal Line" temporary; WarehouseActivityLine: Record "Warehouse Activity Line"): Boolean
var
    Bin: Record Bin;
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeConsumeWarehouseEntryForJobPurchase(TempWarehouseJournalLine, WarehouseActivityLine, IsHandled);
    if IsHandled then
        exit(false);

    if WarehouseActivityLine."Source Document" <> WarehouseActivityLine."Source Document"::"Purchase Order" then
        exit(false);
    // ... rest of the existing code

Event Publisher (add at the end of the codeunit with other integration events):

[IntegrationEvent(false, false)]
local procedure OnBeforeConsumeWarehouseEntryForJobPurchase(var TempWarehouseJournalLine: Record "Warehouse Journal Line" temporary; WarehouseActivityLine: Record "Warehouse Activity Line"; var IsHandled: Boolean)
begin
end;

---

File: WhseActivityPost.Codeunit.al

[JesperSchulz]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 46093.