Refactor Deployment settings & logic in Deploy and DetermineDeploymentEnvironments actions. #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… script - DetermineDeploymentsEnvironments action should not calculate deployment settings (they should be calculated in the Deploy action per environment) - DetermineDeploymentsEnvironments should only calculate shell, runs-on and enviroment name, as they are needed runtime to construct the deployment matrix
…mine environments actions.
…adding support for buildModes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mazhelez
reviewed
Oct 24, 2025
Actions/.Modules/ReadSettings.psm1
Outdated
| $settings.projectName = $project # Default to project path as project name | ||
| } | ||
|
|
||
| $ghEnvironments = @(GetGitHubEnvironments) |
Collaborator
There was a problem hiding this comment.
This will be called on every ReadSettings call, right? Given that GetGitHubEnvironments makes an HTTP call, it seems excessive and unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
Refactor that puts all handling of DeployTo settings into the ReadSettings action instead of letting Deploy and DetermineDeploymentEnvironments handle it.
Related to issue: #
✅ Checklist