Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uasyncio.core: run_until_complete should return coroutine's result #270

Closed
wants to merge 1 commit into from

Conversation

ciniml
Copy link

@ciniml ciniml commented Apr 4, 2018

According to CPython reference, run_until_complete method of EventLoop returns Future's result or raise exception occured inside coroutine, but current run_until_complete method in uasyncio does not return anything.

Since there are no Future object in uasyncio, it's difficult to propagate exception occured inside coroutne. But it's not difficult to return result from coroutine.

This modification fixes the run_until_complete method to return coroutine's result.

@ciniml ciniml changed the title run_until_complete should return coroutine's result uasyncio.core: run_until_complete should return coroutine's result Apr 4, 2018
@jimmo
Copy link
Member

jimmo commented Jul 21, 2023

This was fixed in asyncio v3, and confirmed that the included test in this PR passes.

@jimmo jimmo closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants