Annotation to load SQL before a test @Sql

[timyates]

Started with Spock support

Closes #832

[alvarosanchez]

Would it be too crazy to allow this annotation in other than tests? (at my own risk). I can imagine using it for some of my demos on the Application class

[dstepanov]

If you already working on this code, maybe you can take a look and rewrite the code:

            final List<Property> ps = AnnotationUtils.findRepeatableAnnotations(testClass, Property.class);

To read the annotations from the bean definition, allowing for meta annotations.

[timyates]

Would it be too crazy to allow this annotation in other than tests? (at my own risk). I can imagine using it for some of my demos on the Application class

If we want to do that, we need to decide now as this means the annotation would need a different place to live.

And a different mechanism to invoke it

@micronaut-projects/core-developers do people have thoughts on this?

[sdelamo]

Would it be too crazy to allow this annotation in other than tests? (at my own risk). I can imagine using it for some of my demos on the Application class

If we want to do that, we need to decide now as this means the annotation would need a different place to live.

And a different mechanism to invoke it

@micronaut-projects/core-developers do people have thoughts on this?

I think we could keep @Sql test-only.

However, We could create a similar feature to load data on startup, such as the data.sql and schema.sql in Spring.. I think being able to load automatically data.sql and schema.sql files in src/main/resources would fulfill what @alvarosanchez is describing.

[alvarosanchez]

@sdelamo that would work perfectly, yes

[melix]

Out of curiosity, what is the the benefit of doing this vs using a StartupEvent listener to perform the injection?

[sdelamo]

Out of curiosity, what is the the benefit of doing this vs using a StartupEvent listener to perform the injection?

I assume by injection you mean loading of sql file into the database. What do you mean by "this"? Using @Sql or using data.sql ? The benefit is you don't have to write almost any code. No class with a startup listener. I a guide, I am porting from Spring Boot I had to https://github.com/micronaut-projects/micronaut-guides/pull/1338/files#diff-c930a4c88bedee28367f71ecac1d44d25bebae55251aca4a8247379fde75c384 and this in my test:

    @Inject
    Connection connection;

    @Inject
    ResourceLoader resourceLoader;


    @BeforeEach
    void setUp() throws IOException, SQLException {
        SqlUtils.load(connection, resourceLoader, "sql/seed-data.sql");
    }

[timyates]

To read the annotations from the bean definition, allowing for meta annotations.

We need the properties before we have an application context, which means before we have a specDefinition, so not sure how we can switch to read the Properties from the definition

[timyates]

I think I have a way of supporting R2DBC...

Working on it

[timyates]

I need to investigate the implicit MicronautTest transactions...

I think I need to move where we do the Sql injection...

[timyates]

@dstepanov could you take another look? It supports R2dbc now...

Not sure if we need method level annotation... We can set method level transactions in MicronautTest, so I guess we do...

[sdelamo]

I added the nullability annotations to SqlHandler

[timyates]

I added the nullability annotations to SqlHandler

Thanks! Sorry I missed them in the rewrite 😞

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

63.2% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint