chore(deps-dev): use same versions for artifact upload and download Actions #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
sdelamo
reviewed
Jan 9, 2024
.github/workflows/release.yml
Outdated
| @@ -66,13 +66,13 @@ jobs: | |||
| # Store the hash in a file, which is uploaded as a workflow artifact. | |||
| sha256sum $ARTIFACTS | base64 -w0 > artifacts-sha256 | |||
| - name: Upload build artifacts | |||
| uses: actions/upload-artifact@v4.0.0 | |||
| uses: actions/upload-artifact@v3 | |||
There was a problem hiding this comment.
Can we use an exact version?
Suggested change
| uses: actions/upload-artifact@v3 | |
| uses: actions/upload-artifact@v3.0.0 |
There was a problem hiding this comment.
Done, See commit 71069d1.
sdelamo
requested changes
Jan 9, 2024
.github/workflows/release.yml
Outdated
| with: | ||
| name: gradle-build-outputs | ||
| path: build/repo/${{ steps.publish.outputs.group }}/*/${{ steps.publish.outputs.version }}/* | ||
| retention-days: 5 | ||
| - name: Upload artifacts-sha256 | ||
| uses: actions/upload-artifact@v4.0.0 | ||
| uses: actions/upload-artifact@v3 |
There was a problem hiding this comment.
Can we use an exact version?
Suggested change
| uses: actions/upload-artifact@v3 | |
| uses: actions/upload-artifact@v3.0.0 |
There was a problem hiding this comment.
sdelamo
added a commit
to micronaut-projects/micronaut-mqtt
that referenced
this pull request
Jan 9, 2024
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
sdelamo
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sdelamo Looks like the provenance action
generator_generic_slsa3.ymlis not compatible withactions/download-artifact@v4yet. We need to make sure these two Actions andactions/upload-artifactare all compatible.This PR reverts
actions/download-artifactto v3 for now until the next version ofgenerator_generic_slsa3.ymlthat will be compatible withactions/download-artifact@v4is released. See this relevant issue.