Request body generated in Swagger YAML for POST/PUT with no body

[HoaBo]

This is to reopen micronaut-projects/micronaut-core#1200

I found the related code here

micronaut-openapi/openapi/src/main/java/io/micronaut/openapi/visitor/OpenApiControllerVisitor.java

Line 435 in 23409f4

continue;

If all the body parameters are skipped, e.g. all of them are hidden parameters, then the body will be empty. In this case, I think body should not be required as in

micronaut-openapi/openapi/src/main/java/io/micronaut/openapi/visitor/OpenApiControllerVisitor.java

Line 459 in 23409f4

requestBody.setRequired(true);

Consequences (not related to this repo): when I use codegen to generate client code from the generated swagger.yml, it requires me to pass in an empty object although it shouldn't

[jaecktec]

I think this bug still persists:

when you have a post with a parameter (not a body) like so:

  @Post("/a/{foo}/bar")
  @Status(HttpStatus.NO_CONTENT)
  suspend fun bar(@PathVariable(name = "foo") foo: String) {
    service.bar(foo)
  }

it generates:

  /a/{foo}/bar:
    post:
      operationId: bar
      parameters:
      - name: foo
        in: path
        required: true
        schema:
          type: string
      requestBody:
        content:
          application/json:
            schema:
              type: object
              properties:
                p0:
                  type: string
                  nullable: false

Without that param everything works fine

[swaechter]

@graemerocher @jaecktec Somehow I ran into the same problem for POST and PUT. Is there a workaround to generate an empty request body, e.g via @content / @Schema?

import io.micronaut.http.annotation.Controller;
import io.micronaut.http.annotation.Post;

@Controller("/api")
public class SampleController {

    @Post("/execute")
    public void executePostAction() {
        System.out.println("Hello world!");
    }
}

Produces:

  /api/execute:
    post:
      operationId: executePostAction
      parameters: []
      requestBody:
        content:
          application/json:
            schema:
              type: object
        required: true
      responses:
        "200":
          description: executePostAction 200 response

[jaecktec]

No, but there is still an open issue here: #402