Configuring R2DBC metrics binder #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2022
|
@alvarosanchez There seems to be a problem with permissions in the static analysis. |
graemerocher
approved these changes
Apr 29, 2022
|
@Xicks it's because GitHub won't expose the Sonar secret to a workflow running from a forked repo. Unfortunately, there is nothing that we can do about this, as far as we know. |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding a meter binder for R2DBC pool metrics. Metrics are extracted from class reactor.pool.Pool.PoolMetrics.
I could only bind metrics from class org.reactivestreams.Publisher.ConnectionFactory and casting to io.r2dbc.pool.ConnectionPool when possible, because the way Micrometer register the ConnectionPool.
It is my first time contributing so I did not know how to document the version in JavaDocs. I used the next version 4.2.1.