Add option to customise close() wait (fixes #901)

[agarciadom]

This pull request proposes a new option to customise how long we wait for each KafkaStreams to close, as a fix for #901.

If you have a better idea for the name of the option, please let me know. I was not sure whether to go with kafka.streams.close-seconds or kafka.streams-close-seconds.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jeremyg484
❌ agarciadom
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[sdelamo]

@jeremyg484 please, follow-up this PR from @agarciadom

[jeremyg484]

@agarciadom Thanks for your initial work on this. I've gone ahead and picked up the PR and done the configuration in a bit more of a typical Micronaut way using @ConfigurationProperties as Sergio had suggested above. If you get a chance to try these updates out to ensure it satisfies your use case that would be great!

[agarciadom]

Thank you for the changes! Apologies for not being able to do it myself: I was busy with my teaching and I wasn't entirely sure about how to follow the suggested approach.

I'll try out your proposed changes :-).

[agarciadom]

I can confirm that with the PR, I can replace my manual workaround with this addition to my application-test.yml file:

kafka:
  streams:
    default:
      close-timeout: 60s

I'm not sure why it takes so long to shutdown after my last test (that's for another discussion, I guess!), but at least it does get the tests to pass.

Thank you for your work!

[jeremyg484]

I can confirm that with the PR, I can replace my manual workaround with this addition to my application-test.yml file:

kafka:
  streams:
    default:
      close-timeout: 60s

I'm not sure why it takes so long to shutdown after my last test (that's for another discussion, I guess!), but at least it does get the tests to pass.

Thank you for your work!

Great, glad it's working for you!

I've been seeing the same issue with it taking a long time to shutdown the streams sometimes in our tests. As far as I can tell, it's something purely on the Kafka side of things and not anything we're doing wrong in the module. It is something I intend to dig into separately though as it's making running the whole streams test suite quite sluggish.