Publish events after Consumer subscribes and after first polling #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermocalvo
force-pushed
the
feature/consumer-subscribed-polling-events
branch
from
28170c2
to
e5be318
Compare
|
I rebased this branch and added tests. |
jeremyg484
suggested changes
Jul 26, 2023
| * Abstract base class for all kafka application events. | ||
| * | ||
| * @author Jorge F. Sanchez | ||
| * @since 4.5.3 |
There was a problem hiding this comment.
The @since in these new classes will need to be updated to either 5.0.3, or 5.1.0. As this introduces new event types, I'm thinking 5.1.0 would be more appropriate. @sdelamo would you agree?
kafka/src/main/java/io/micronaut/configuration/kafka/event/AbstractKafkaApplicationEvent.java
Show resolved
Hide resolved
...a/src/main/java/io/micronaut/configuration/kafka/event/KafkaConsumerStartedPollingEvent.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/event/KafkaConsumerSubscribedEvent.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeremy Grelle <grellej@unityfoundation.io>
Co-authored-by: Jeremy Grelle <grellej@unityfoundation.io>
jeremyg484
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Looks good to me, other than needing to make a decision on what version this belongs to and updating the @since tags accordingly. I'll trust @sdelamo to make that call.
sdelamo
requested changes
Aug 4, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/event/AbstractKafkaApplicationEvent.java
Outdated
Show resolved
Hide resolved
...a/src/main/java/io/micronaut/configuration/kafka/event/KafkaConsumerStartedPollingEvent.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/event/KafkaConsumerSubscribedEvent.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
Outdated
Show resolved
Hide resolved
…tractKafkaApplicationEvent.java
…kaConsumerStartedPollingEvent.java
…kaConsumerSubscribedEvent.java
sdelamo
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a solution for #457