partial fix for #110, call Deserializer#configure and Serializer#configure #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs test coverage |
edeesis
force-pushed
the
partial-fix-110
branch
from
db9da3e
to
ac83f16
Compare
|
@graemerocher Apologies for the delay. I have added a test, but it might not be exactly what you're looking for. Happy to make any additional changes. |
edeesis
force-pushed
the
partial-fix-110
branch
2 times, most recently
from
07f7457
to
bc784bf
Compare
graemerocher
added
the
type: improvement
…nd Serializer#configure when KafkaConsumerProcessor sets the serde beans in Consumer and Producer configuration
guillermocalvo
force-pushed
the
partial-fix-110
branch
from
bc784bf
to
6a566be
Compare
|
I just rebased this branch, updated the test for custom consumer deserializers, and added one more for custom producer serializers. |
jeremyg484
suggested changes
Jul 26, 2023
kafka/src/test/groovy/io/micronaut/configuration/kafka/KafkaConfigurationSpec.groovy
Outdated
Show resolved
Hide resolved
jeremyg484
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix for #110
when KafkaConsumerProcessor sets the serde beans in Consumer and Producer configuration
This will allow users to inform their custom serdes on whether this is a key or a value serde.