Add support to infer kafka key and value deserializer types when batch is enabled #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
KaustubhKhati
approved these changes
Oct 18, 2022
dhofftgt
force-pushed
the
infer-batch-deserializers
branch
3 times, most recently
from
7659056
to
bcee29b
Compare
…nsumerRecords It looks like when using a batch listener with a parameter of List<ConsumerRecord<K,V>> the framework picks a List deserializer instead of looking at the ConsumerRecord type args. With this change, it will look at the type args of the ConsumerRecord to determine the kafka message deserializer
dhofftgt
force-pushed
the
infer-batch-deserializers
branch
from
bcee29b
to
7805a2f
Compare
Crow-EH
approved these changes
Nov 25, 2022
|
Hi, is there any ETA when this change is being released? I am desperately looking to incorporate this change :-) Thanks in advance for an answer @graemerocher . |
|
Can we release this? #811 |
sdelamo
pushed a commit
that referenced
this pull request
Mar 22, 2024
…nsumerRecords (#598) It looks like when using a batch listener with a parameter of List<ConsumerRecord<K,V>> the framework picks a List deserializer instead of looking at the ConsumerRecord type args. With this change, it will look at the type args of the ConsumerRecord to determine the kafka message deserializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into #502. Taking a stab at fixing it.
It looks like when using a batch listener with a parameter of List<ConsumerRecord<K,V>> the framework picks a List deserializer instead of looking at the ConsumerRecord type args. With this change, it will look at the type args of the ConsumerRecord to determine the kafka message deserializer
This should resolve #502