-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: on binaryCompatibility & build to 5.3.14 #579
Conversation
@@ -2,12 +2,6 @@ plugins { | |||
id 'io.micronaut.build.internal.kafka-module' | |||
} | |||
|
|||
micronautBuild { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Binary compatibility was turned off 229bd9b
@@ -1,6 +1,5 @@ | |||
projectVersion=4.4.0-SNAPSHOT | |||
projectGroup=io.micronaut.kafka | |||
micronautSharedSettingVersion=5.3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved this directly to settings to align to the project template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not sure why everything in this module is failing on graal 17/latest
https://ge.micronaut.io/s/xwpap35vvdydi/console-log?task=:tests:tasks-sasl-plaintext:nativeCompile
@@ -1,6 +1,6 @@ | |||
pluginManagement { | |||
plugins { | |||
id 'io.micronaut.build.shared.settings' version getProperty("micronautSharedSettingVersion") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can modify the version in gradle properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understand. But we should keep the project's build aligned. Please note that having the version in settings.gradle
, gets automatic version upgrades PR. No downside in terms of automatic updates.
If we want to define build tools version in gradle.properties
we should change it in project template and then use it in every project.
Kudos, SonarCloud Quality Gate passed! |
@sdelamo 💚 |
No description provided.