Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: on binaryCompatibility & build to 5.3.14 #579

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jul 27, 2022

No description provided.

@@ -2,12 +2,6 @@ plugins {
id 'io.micronaut.build.internal.kafka-module'
}

micronautBuild {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary compatibility was turned off 229bd9b

@@ -1,6 +1,5 @@
projectVersion=4.4.0-SNAPSHOT
projectGroup=io.micronaut.kafka
micronautSharedSettingVersion=5.3.10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved this directly to settings to align to the project template

@sdelamo sdelamo added this to the 4.4.0 milestone Jul 27, 2022
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure why everything in this module is failing on graal 17/latest

https://ge.micronaut.io/s/xwpap35vvdydi/console-log?task=:tests:tasks-sasl-plaintext:nativeCompile

@graemerocher
Copy link
Contributor

@timyates let's see if c134128 reveals any more

@timyates
Copy link
Contributor

@graemerocher #581 🤞

@@ -1,6 +1,6 @@
pluginManagement {
plugins {
id 'io.micronaut.build.shared.settings' version getProperty("micronautSharedSettingVersion")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can modify the version in gradle properties

Copy link
Contributor Author

@sdelamo sdelamo Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I understand. But we should keep the project's build aligned. Please note that having the version in settings.gradle, gets automatic version upgrades PR. No downside in terms of automatic updates.

If we want to define build tools version in gradle.properties we should change it in project template and then use it in every project.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@timyates
Copy link
Contributor

@sdelamo 💚

@sdelamo sdelamo merged commit 253406e into master Jul 28, 2022
@sdelamo sdelamo deleted the enable-binary branch July 28, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants