Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of builders with inheritance #9926

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Fix handling of builders with inheritance #9926

merged 2 commits into from
Sep 27, 2023

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Sep 27, 2023 •
edited by graemerocher
Loading

Super methods were not being scanned, this fixes that

@graemerocher graemerocher marked this pull request as ready for review September 27, 2023 14:49
@graemerocher graemerocher changed the title Test case for super builder support Fix handling of builders with inheritance Sep 27, 2023
@graemerocher graemerocher added the type: bug Something isn't working label Sep 27, 2023
@graemerocher graemerocher added this to the 4.0.7 milestone Sep 27, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@yawkat yawkat merged commit a921771 into 4.1.x Sep 27, 2023
@yawkat yawkat deleted the super-builder branch September 27, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
4.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@yawkat @graemerocher