Skip to content

Fix empty header value validation #9909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix empty header value validation #9909

merged 1 commit into from
Sep 22, 2023

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Sep 22, 2023

Field values can be empty according to https://httpwg.org/specs/rfc9110.html#fields.values .

Fixes #9907

@yawkat yawkat added the type: bug Something isn't working label Sep 22, 2023
@yawkat yawkat added this to the 4.1.7 milestone Sep 22, 2023
@yawkat yawkat requested a review from timyates September 22, 2023 08:53
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the HTTP header spec... 😿

@timyates
Copy link
Contributor

@sdelamo late addition for 4.1.2?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@yawkat yawkat merged commit 5ed3eb3 into 4.1.x Sep 22, 2023
@yawkat yawkat deleted the empty-header-value branch September 22, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Passing HTTP empty headers leads to StringIndexOutOfBoundException being thrown
2 participants