Support Client Filters Pass in the JDK client #9700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't use them yet, but passes them through
this cuts down on the amount of code we need to write and test
|
Fixed up the logging as per #9710 (so we don't lose it in the merge) |
sdelamo
requested changes
Aug 14, 2023
http-client-jdk/src/main/java/io/micronaut/http/client/jdk/AbstractJdkHttpClient.java
Outdated
Show resolved
Hide resolved
yawkat
approved these changes
Aug 14, 2023
* remove extra blank lines
* close server
* use SocketUtils.findAvailablePort
* remove unncessary ("/") from @get and @post
* remove extra blank lines
* remove unnecessary return
* use @MicronautTest
* extract clientFilterEntries method
* log with headers with HttpHeadersUtil
* use @ClientFilter and @ResponseFilter
* Update StaticClientFilterSpec.groovy * Fix the same test in the netty client --------- Co-authored-by: Tim Yates <tim.yates@gmail.com>
sdelamo
approved these changes
Aug 14, 2023
|
Kudos, SonarCloud Quality Gate passed! |
timyates
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables Http Client Filters for the JDK client.