Use Map.of instead of custom implementation
#9032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
yawkat
reviewed
Mar 31, 2023
| } | ||
| } | ||
|
|
||
| public static boolean isSupportedMapValue(Object value) { |
There was a problem hiding this comment.
i think this should just be a giant ||
yawkat
approved these changes
Mar 31, 2023
graemerocher
approved these changes
Mar 31, 2023
graemerocher
added
the
type: improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Java's
Map.ofis more performant than ourImmutableSortedStringsArrayMap, I think it's better to use the native implementation.We still have to keep the previous implementation till everything is recompiled and all nulls in map values are eliminated.
There are some stats:
Before:
AnnotationValueBenchmark.benchMarkGetValue thrpt 5 4686109.127 ± 176737.942 ops/s
After:
AnnotationValueBenchmark.benchMarkGetValue thrpt 5 4999775.733 ± 276019.217 ops/s
Before:
FullHttpStackBenchmark.test MICRONAUT avgt 30 20530.775 ± 252.348 ns/op
After:
FullHttpStackBenchmark.test MICRONAUT avgt 30 19438.006 ± 94.318 ns/op