Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version parsing #8897

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fix version parsing #8897

merged 1 commit into from
Mar 7, 2023

Conversation

melix
Copy link
Contributor

@melix melix commented Mar 7, 2023

The previous check assumed that we could only find -SNAPSHOT, but for a release, we may have -M1 or -beta-1, etc.

Fixes error seen at https://ge.micronaut.io/s/aenwsqygoz6ik

The previous check assumed that we could only find `-SNAPSHOT`, but for a release,
we may have `-M1` or `-beta-1`, etc.

Fixes error seen at https://ge.micronaut.io/s/aenwsqygoz6ik
@melix melix requested a review from sdelamo March 7, 2023 11:06
@melix melix self-assigned this Mar 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@graemerocher graemerocher merged commit 7f62cc5 into 4.0.x Mar 7, 2023
@graemerocher graemerocher deleted the cc/fix-parsing branch March 7, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants