Support JsonNaming and JsonProperty for BeanIntrospectionModule #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for JsonNaming was missing (same for the `property-naming-strategy` config property), and support for JsonProperty was spotty. This implements support for both. Also removed some old code that special-cased the property names for `Resource`. Not needed anymore since #6254 Fixes #6904 Fixes #6665 Fixes #7129 Fixes micronaut-security/#946
graemerocher
requested changes
Mar 24, 2022
Comment on lines
238
to
246
| if (clazz.isPresent()) { | ||
| try { | ||
| Constructor<?> emptyConstructor = clazz.get().getConstructor(); | ||
| return (PropertyNamingStrategy) emptyConstructor.newInstance(); | ||
| } catch (NoSuchMethodException ignored) { | ||
| } catch (ReflectiveOperationException e) { | ||
| throw new RuntimeException("Failed to construct configured PropertyNamingStrategy", e); | ||
| } | ||
| } |
There was a problem hiding this comment.
You can use InstantiationUtils.tryInstantiate for this
There was a problem hiding this comment.
i want to distinguish between constructor failure (-> error) and no constructor being present (-> default behavior)
jackson-databind/src/main/java/io/micronaut/jackson/modules/BeanIntrospectionModule.java
Outdated
Show resolved
Hide resolved
|
the sonar failure is because the graal feature cant be tested |
graemerocher
approved these changes
Mar 24, 2022
sdelamo
reviewed
Mar 30, 2022
...son-databind/src/test/groovy/io/micronaut/jackson/modules/BeanIntrospectionModuleSpec.groovy
Outdated
Show resolved
Hide resolved
...son-databind/src/test/groovy/io/micronaut/jackson/modules/BeanIntrospectionModuleSpec.groovy
Show resolved
Hide resolved
jackson-databind/src/main/java/io/micronaut/jackson/modules/BeanIntrospectionModule.java
Show resolved
Hide resolved
jackson-databind/src/main/java/io/micronaut/jackson/modules/BeanIntrospectionModule.java
Show resolved
Hide resolved
sdelamo
approved these changes
Mar 30, 2022
| } catch (NoSuchMethodException ignored) { | ||
| return mapperConfig.getPropertyNamingStrategy(); | ||
| } catch (ReflectiveOperationException e) { | ||
| throw new RuntimeException("Failed to construct configured PropertyNamingStrategy", e); |
There was a problem hiding this comment.
I have addressed two sonar issues. The one remaning is that it is telling us to use a less generic exception.
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for JsonNaming was missing (same for the
property-naming-strategyconfig property), and support for JsonProperty was spotty. This implements both.Also removed some old code that special-cased the property names for
Resource. Not needed anymore since #6254Fixes #6904
Fixes #6665
Fixes #7129
Fixes micronaut-security/#946