Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how suspend function results are mapped #3699

Merged
merged 3 commits into from
Jul 12, 2020
Merged

Fix how suspend function results are mapped #3699

merged 3 commits into from
Jul 12, 2020

Conversation

jameskleeh
Copy link
Contributor

Fixes #3667

@jameskleeh
Fix how suspend function results are passed through. Now filters will…
c93654a 
… get an appropriate response based on the result of the body stream. Fixes #3667
@jameskleeh
Copy link
Contributor Author

Previously for suspend functions we were effectively returning HttpResponse.OK.body(someFlowable). The filters that listened to the onNext were getting a response with OK even though the resulting body could throw an error and result in an error response being sent. This changes the result to be Flowable<HttpResponse> so that filters will have the correct response.

@jameskleeh jameskleeh requested a review from graemerocher July 9, 2020 16:13
@graemerocher graemerocher added this to the 2.0.1 milestone Jul 10, 2020
@jameskleeh jameskleeh requested a review from graemerocher July 10, 2020 16:29
@graemerocher graemerocher merged commit 4e0f68f into master Jul 12, 2020
@graemerocher graemerocher deleted the issue-3667 branch July 12, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

Invalid status in metrics when an exception is thrown (Micronaut 2.0)
2 participants
@jameskleeh @graemerocher