Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle class arrays in annotation metadata #3519

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Handle class arrays in annotation metadata #3519

merged 1 commit into from
Jun 22, 2020

Conversation

jameskleeh
Copy link
Contributor

Fixes #3481

@jameskleeh jameskleeh linked an issue Jun 19, 2020 that may be closed by this pull request
No introspection data created/returned for array classes #3481
Closed
graemerocher
graemerocher requested changes Jun 19, 2020
View reviewed changes
...ct-groovy/src/test/groovy/io/micronaut/inject/annotation/AnnotationMetadataWriterSpec.groovy

expect:
metadata.stringValues(TypeHint).size() == 2
metadata.stringValues(TypeHint)[0] == '[Ljava.util.UUID;'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you do metadata.classValues(TypeHint)[0]? Need a test here

@graemerocher graemerocher merged commit e317742 into master Jun 22, 2020
@graemerocher graemerocher deleted the issue-3481 branch June 22, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No introspection data created/returned for array classes
2 participants
@jameskleeh @graemerocher