Remove thread factory tracing #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well this is what we have RCs for. It would be could if this was a test included that demonstrated the issue |
|
I didn't manage to reproduce it by a test in micronaut, in a private project I managed to point it out to only netty threads wrapping, I suspected client and server are sharing the same thread pool and when client is called from a controller context is propagated to a new runnable wrapper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, thread factory tracing is causing all kind of issues, the problem occurs when the thread is actually a long-running reusable.
The first invocation will set server context, MDC, and tracing of the first request, and in RC1 it's causing that first server request object being set again.