Client filter by annotation #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public HttpClientFilterResolver( | ||
| @Parameter @Nullable Collection<String> clientIdentifiers, | ||
| @Parameter @Nullable AnnotationValue annotationValue, |
There was a problem hiding this comment.
There might be multiple filters with customer stereotype annotations. Taking into account we are passing information about just one annotation into resolver, is it correct to assume Micronaut will not support a case when multiple client annotations are applied on a client?
For example with a current implementation apparently it won't be possible to do something like
@Metered @OauthClientCredentials @Client() SomeClient client, correct?
There was a problem hiding this comment.
@svishnyakoff Currently that is correct. If you'd like to create a separate issue for the enhancement of the feature that would be OK
|
Could you resolve the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.