Add a HEAD route for every GET #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,7 +94,7 @@ public void process(BeanDefinition<?> beanDefinition, ExecutableMethod<?, ?> met | |||
| String functionName = beanDefinition.getValue(FunctionBean.class, String.class).orElse(methodName); | |||
| String functionMethod = beanDefinition.getValue(FunctionBean.class, "method", String.class).orElse(null); | |||
|
|
|||
| UriRoute route = null; | |||
| List<UriRoute> routes = new ArrayList<>(); | |||
There was a problem hiding this comment.
Specify size of 2 to the array
|
Failing tests? |
|
Looks to be set ordering funny business: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1489.
If you know of a better way of going about this let me know. I tried to do it in the abstract route builder itself but since only a single route is returned, the caller would have no way of further processing the route.