Feature/Support for QueryValue as a object #11787

MarianConstantinMarica · 2025-04-28T13:59:11Z

No description provided.

…g POJO

…ndingSpec

…tters

CLAassistant · 2025-04-28T13:59:18Z

All committers have signed the CLA.

yawkat · 2025-04-28T19:02:41Z

@dstepanov can you think of a better way to do this? otherwise i think it's ok

altro3 · 2025-04-29T14:15:04Z

http/src/main/java/io/micronaut/http/bind/binders/QueryValueArgumentBinder.java

+        BeanIntrospection<T> introspection = introspectionOpt.get();
+        T instance;
+        try {
+            instance = introspection.instantiate();


Why no-args constructor is required? I'think you need more tests with record and required args constructor (without no-arg)

I will update!

graemerocher · 2025-04-29T14:17:36Z

http/src/main/java/io/micronaut/http/bind/binders/QueryValueArgumentBinder.java

+            return BindingResult.unsatisfied();
+        }
+
+        BeanIntrospection<T> introspection = introspectionOpt.get();


this should be altered to use introspection.builder() so that records, immutable types, types with custom constructors etc. are supported.

When using IntrospectionBuilder API and finally call the build() method any exception should b caught and the conversion rejected with context.reject

I made the changes with the introspection.builder(). Seems to work for object with custom constructor but I made a test for record and don't work. Am I missing something?

this is because records are not supported in Groovy and you a rewriting the test in Groovy. Probably will be fixed by #11832

…s, types with custom constructors etc.

http/src/main/java/io/micronaut/http/bind/binders/QueryValueArgumentBinder.java

graemerocher · 2025-05-04T08:33:39Z

http/src/main/java/io/micronaut/http/bind/binders/QueryValueArgumentBinder.java

+        BeanIntrospection<T> introspection = introspectionOpt.get();
+        BeanIntrospection.Builder<T> introspectionBuilder = introspection.builder();
+
+        for (BeanProperty<T, Object> property : introspection.getBeanProperties()) {


iterative here over the getBuilderArguments() using array iteration to obtain the index

http/src/main/java/io/micronaut/http/bind/binders/QueryValueArgumentBinder.java

graemerocher · 2025-05-04T08:35:14Z

http/src/main/java/io/micronaut/http/bind/binders/QueryValueArgumentBinder.java

+                Optional<Object> converted = conversionService.convert(value.get(), context.with(property.asArgument()));
+                if (converted.isPresent()) {
+                    try {
+                        introspectionBuilder.with(propertyName, converted.get());


invoke with passing the index from the array iteration https://docs.micronaut.io/latest/api/io/micronaut/core/beans/BeanIntrospection.Builder.html#with(int,io.micronaut.core.type.Argument,A)

I tried with getBuilderArguments() iteration, still not working for the records

altro3 · 2025-06-09T17:44:26Z

http-server-netty/src/test/groovy/io/micronaut/http/server/netty/binding/PaginationRequest.java

+import io.micronaut.core.annotation.Introspected;
+
+@Introspected
+public record PaginationRequest(Integer page, Integer size) {}


@MarianConstantinMarica just rename PaginationRequest.java to PaginationRequest.groovy and after this all must work correctly

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

# Conflicts: # gradle.properties # inject-java/src/test/resources/META-INF/services/io.micronaut.inject.visitor.TypeElementVisitor

….10.x-upd Merge 4.9.x

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…bject

…ronaut-projects#11880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…icronaut-projects#11896) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…-projects#11899) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

# Conflicts: # gradle.properties

….10.x-merge 4.9.x->4.10.x merge

…ec to better reflect its actual contents. (micronaut-projects#11874) The default order of an object in OrderUtil.getOrder should be zero not LOWEST_PRECEDENCE, as otherwise there is no way to request a bean be last in the list. The intention here is to leave a bean that doesn't request an order un-ordered relative to other beans, so zero is the correct value. Apply a global ordering to all bean event listeners regardless of requested generic type. Previously, listeners were ordered only relative to other listeners that specified the same generic type, meaning the final ordering could be unexpected in cases where supertypes were matched. Ordering is now done after all the listeners are aggregated.

…ronaut-projects#11909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…180 (micronaut-projects#11903) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…cronaut-projects#11922) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

See: micronaut-projects/micronaut-openapi#2180

…11927) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ects#11774) For motivation and rationale see micronaut-projects#11655

… to v1.6.16 (micronaut-projects#11940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Used for future PEM loading PR.

…ects#11934) * Add new OutputStream buffer method to ByteBodyFactory This will be useful for micronaut-jax-rs optimizations. * CR

…11945) * fix(deps): update netty monorepo to v4.2.3.final * remove obsolete deletions * build time init --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: yawkat <jonas.konrad@oracle.com>

) This PR adds support for loading PEM files in place of key and trust stores. - Introduce a PemParser class that can load various PEM types: PKCS#8 private keys (possibly encrypted), PKCS#1 private keys, SEC.1 elliptic curve keys, X.509 certificates. This is a bit complicated because we need to do some content sniffing. - If key store loading fails from a path, also try loading it as PEM. For key stores, the expected format is a single PRIVATE KEY followed by some CERTIFICATEs, while for a trust store it expects a set of CERTIFICATEs. - Add properties to KeyStoreConfiguration for separate key and certificate files, since keeping them separate is more common in practice (incl. in the docs) - Update docs

…181 (micronaut-projects#11953) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…icronaut-projects#11946) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…-projects#11959) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…bject

MarianConstantinMarica added 5 commits April 26, 2025 05:03

micronaut-projectsgh-11473: expand QueryValueArgumentBinder to bindin…

8f061b2

…g POJO

micronaut-projectsgh-11473: create a test for endpoint in ParameterBi…

90cdb0a

…ndingSpec

micronaut-projectsgh-11473: fix issue with bindSimple

10ed6d2

micronaut-projectsgh-11473: fix issue with bindPojo

1c985b7

micronaut-projectsgh-11473: add empty constructor in Book pojo and se…

cac5b32

…tters

MarianConstantinMarica mentioned this pull request Apr 28, 2025

Support for QueryValue as a object #11473

Open

micronaut-projectsgh-11473: remove unused imports

f0fb8f7

yawkat requested a review from dstepanov April 28, 2025 19:02

yawkat approved these changes Apr 28, 2025

View reviewed changes

altro3 suggested changes Apr 29, 2025

View reviewed changes

graemerocher requested changes Apr 29, 2025

View reviewed changes

MarianConstantinMarica added 2 commits April 29, 2025 07:56

gh:11473: use introspection.builder() so that records, immutable type…

2513fda

…s, types with custom constructors etc.

micronaut-projectsgh-11473: create a test for record

a1745b4

graemerocher requested changes May 4, 2025

View reviewed changes

MarianConstantinMarica and others added 2 commits May 4, 2025 02:37

micronaut-projectsgh-11473: use getBuilderArguments()

6e9a62f

fix tests

88ddb6a

altro3 reviewed Jun 9, 2025

View reviewed changes

sdelamo and others added 11 commits June 10, 2025 09:34

projectVersion=4.10.0-SNAPSHOT [ci skip]

797c29f

fix(deps): update managed.reactor to v3.7.7 (micronaut-projects#11850)

21dd30a

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Allow visiting imported classes + Mixin (micronaut-projects#11845)

77e0a29

Merge branch '4.9.x' into 4.10.x-upd

3a7cccf

# Conflicts: # gradle.properties # inject-java/src/test/resources/META-INF/services/io.micronaut.inject.visitor.TypeElementVisitor

Merge pull request micronaut-projects#11866 from micronaut-projects/4…

ed0da60

….10.x-upd Merge 4.9.x

fix(deps): update vertx to v4.5.15 (micronaut-projects#11868)

b816e29

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update bytebuddy to v1.17.6 (micronaut-projects#11877)

9f096ad

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Merge branch 'micronaut-projects:4.10.x' into feature/queryvalue-as-o…

d11b231

…bject

chore(deps): update softprops/action-gh-release action to v2.3.2 (mic…

6ca80dc

…ronaut-projects#11880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency io.methvin:directory-watcher to v0.19.1 (m…

089a955

…icronaut-projects#11896) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update graalvm/setup-graalvm action to v1.3.4 (micronaut…

415e536

…-projects#11899) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

graemerocher and others added 23 commits June 26, 2025 08:14

Merge branch '4.9.x' into 4.10.x

b18fba0

Merge branch '4.9.x' into 4.10.x-merge

0fe6d17

# Conflicts: # gradle.properties

Merge pull request micronaut-projects#11923 from micronaut-projects/4…

c21dd7e

….10.x-merge 4.9.x->4.10.x merge

fix(deps): update dependency org.testcontainers:spock to v1.21.3 (mic…

4bc953e

…ronaut-projects#11909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency io.github.classgraph:classgraph to v4.8.…

5b6c18d

…180 (micronaut-projects#11903) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency org.zalando:logbook-netty to v3.12.2 (mi…

d24a371

…cronaut-projects#11922) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update vertx to v4.5.16 (micronaut-projects#11924)

52e429f

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Remove postfix for dummy file (micronaut-projects#11846)

0477afc

See: micronaut-projects/micronaut-openapi#2180

chore(deps): update dependency gradle to v8.14.3 (micronaut-projects#…

abd82b8

…11927) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Added factory class for InstantSource bean creation (micronaut-proj…

4b49f6c

…ects#11774) For motivation and rationale see micronaut-projects#11655

fix(deps): update dependency com.blazebit:blaze-persistence-core-impl…

a441e9f

… to v1.6.16 (micronaut-projects#11940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Add string: and base64: resource loaders (micronaut-projects#11937)

03f8d90

Used for future PEM loading PR.

Add new OutputStream buffer method to ByteBodyFactory (micronaut-proj…

fd29a66

…ects#11934) * Add new OutputStream buffer method to ByteBodyFactory This will be useful for micronaut-jax-rs optimizations. * CR

fix(deps): update dependency io.github.classgraph:classgraph to v4.8.…

185a834

…181 (micronaut-projects#11953) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update jackson monorepo to v2.19.2 (micronaut-projects#11955)

b12ade7

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency org.graalvm.sdk:nativeimage to v23.1.8 (m…

d856c6d

…icronaut-projects#11946) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update managed.reactor to v3.7.8 (micronaut-projects#11957)

39147ef

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update graalvm/setup-graalvm action to v1.3.5 (micronaut…

b4e785a

…-projects#11959) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update groovy monorepo to v4.0.28 (micronaut-projects#11962)

6883af3

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Merge branch 'micronaut-projects:4.10.x' into feature/queryvalue-as-o…

3034e59

…bject

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/Support for QueryValue as a object #11787

Feature/Support for QueryValue as a object #11787

Uh oh!

MarianConstantinMarica commented Apr 28, 2025

Uh oh!

CLAassistant commented Apr 28, 2025 •

edited

Loading

Uh oh!

yawkat commented Apr 28, 2025

Uh oh!

altro3 Apr 29, 2025

Uh oh!

MarianConstantinMarica Apr 29, 2025

Uh oh!

graemerocher Apr 29, 2025 •

edited

Loading

Uh oh!

graemerocher Apr 29, 2025

Uh oh!

MarianConstantinMarica Apr 29, 2025

Uh oh!

graemerocher Jun 9, 2025

Uh oh!

Uh oh!

graemerocher May 4, 2025

Uh oh!

Uh oh!

Uh oh!

graemerocher May 4, 2025

Uh oh!

MarianConstantinMarica May 4, 2025

Uh oh!

altro3 Jun 9, 2025

Uh oh!

Uh oh!

Feature/Support for QueryValue as a object #11787

Are you sure you want to change the base?

Feature/Support for QueryValue as a object #11787

Uh oh!

Conversation

MarianConstantinMarica commented Apr 28, 2025

Uh oh!

CLAassistant commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yawkat commented Apr 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

graemerocher Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CLAassistant commented Apr 28, 2025 •

edited

Loading

graemerocher Apr 29, 2025 •

edited

Loading