Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document how to Disable hostname verification in ssl config #11526

Open
wants to merge 4 commits into
base: 4.8.x
Choose a base branch
from
Open

doc: document how to Disable hostname verification in ssl config #11526

wants to merge 4 commits into from

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jan 22, 2025

@sdelamo sdelamo requested review from yawkat and graemerocher and removed request for yawkat January 22, 2025 17:12
@sdelamo @yawkat
Update http-client/src/main/java/io/micronaut/http/client/netty/ssl/N…
a62f354 
…ettyClientSslBuilder.java

Co-authored-by: Jonas Konrad <jonas.konrad@oracle.com>
yawkat
yawkat approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@yawkat yawkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, this feature is niche enough that this is a better solution.

@yawkat yawkat mentioned this pull request Jan 23, 2025
Closed
sdelamo and others added 2 commits January 30, 2025 13:30
@sdelamo @graemerocher
Update src/main/docs/guide/httpClient/httpClientImplementations/netty…
2a00657 
…HttpClient.adoc

Co-authored-by: Graeme Rocher <graeme.rocher@oracle.com>
@sdelamo @graemerocher
Update src/main/docs/guide/httpClient/httpClientImplementations/netty…
98b446e 
…HttpClient.adoc

Co-authored-by: Graeme Rocher <graeme.rocher@oracle.com>
@sdelamo sdelamo requested a review from graemerocher January 30, 2025 12:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat yawkat approved these changes

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees
No one assigned
Labels
type: docs
Projects
4.8.0 Release
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdelamo @graemerocher @yawkat