Use sourcegen bytecode generator to generate internal metadata #11407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
requested changes
Dec 4, 2024
inject/src/main/java/io/micronaut/inject/beans/AbstractInitializableBeanIntrospection.java
Outdated
Show resolved
Hide resolved
| defaultsStorage, | ||
| loadTypeMethods | ||
| public static byte[] write(String className, AnnotationMetadata annotationMetadata) { | ||
| Map<String, MethodDef> loadTypeMethods = new HashMap<>(); |
There was a problem hiding this comment.
should this be a linked hash map? Will it impact the order of the methods written?
There was a problem hiding this comment.
Fixed, it's only used for testing anyway
core-processor/src/main/java/io/micronaut/inject/annotation/AnnotationMetadataWriter.java
Outdated
Show resolved
Hide resolved
core-processor/src/main/java/io/micronaut/aop/writer/AopProxyWriter.java
Show resolved
Hide resolved
core-processor/src/main/java/io/micronaut/aop/writer/AopProxyWriter.java
Outdated
Show resolved
Hide resolved
core-processor/src/main/java/io/micronaut/aop/writer/AopProxyWriter.java
Outdated
Show resolved
Hide resolved
| * @param p The class element | ||
| * @return The string representation | ||
| */ | ||
| private static String toTypeString(ClassElement p) { |
There was a problem hiding this comment.
this seems like something that belongs in ClassElement or a utility method
There was a problem hiding this comment.
Not sure, we just do some unique string from a class
core-processor/src/main/java/io/micronaut/inject/writer/BeanDefinitionWriter.java
Outdated
Show resolved
Hide resolved
core-processor/src/main/java/io/micronaut/inject/writer/BeanDefinitionWriter.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR rewrites all the class writers (except the evaluated expressions writer) to use a new bytecode generator from Micronaut Sourcegen.
I haven't done any major refactoring. Some classes like
BeanDefnitionWriteris too big and need some refactoring