Skip to content

Commit

Permalink
build: remove dependency to validation dependency from core (#8914)
Browse files Browse the repository at this point in the history
This PR removes validation as a dependency of http-server-tck and http-tck
---------

Co-authored-by: Graeme Rocher <graeme.rocher@oracle.com>
  • Loading branch information
sdelamo and graemerocher authored Mar 11, 2023
1 parent a1bfa02 commit 2f5c857
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Build with Gradle
id: gradle
run: |
./gradlew check --no-daemon --parallel --continue
./gradlew preReleaseCheck check --no-daemon --parallel --continue
env:
GH_TOKEN_PUBLIC_REPOS_READONLY: ${{ secrets.GH_TOKEN_PUBLIC_REPOS_READONLY }}
GH_USERNAME: ${{ secrets.GH_USERNAME }}
Expand Down
4 changes: 2 additions & 2 deletions http-server-tck/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ dependencies {
}
annotationProcessor(projects.httpValidation)

implementation(platform(libs.test.boms.micronaut.validation))
implementation(libs.micronaut.validation) {
compileOnly(platform(libs.test.boms.micronaut.validation))
compileOnly(libs.micronaut.validation) {
exclude(group = "io.micronaut")
}
implementation(projects.runtime)
Expand Down
4 changes: 2 additions & 2 deletions http-tck/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ dependencies {
}
annotationProcessor(projects.httpValidation)

implementation(platform(libs.test.boms.micronaut.validation))
implementation(libs.micronaut.validation) {
compileOnly(platform(libs.test.boms.micronaut.validation))
compileOnly(libs.micronaut.validation) {
exclude(group = "io.micronaut")
}
implementation(projects.runtime)
Expand Down
9 changes: 9 additions & 0 deletions test-suite-http-server-tck-jdk/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ dependencies {
testImplementation(projects.httpClientJdk)
testImplementation(projects.httpServerTck)
testImplementation(libs.junit.platform.engine)
testAnnotationProcessor(platform(libs.test.boms.micronaut.validation))
testAnnotationProcessor(libs.micronaut.validation.processor) {
exclude(group = "io.micronaut")
}
testImplementation(platform(libs.test.boms.micronaut.validation))
testImplementation(libs.micronaut.validation) {
exclude(group = "io.micronaut")
}

}

tasks.withType(Test::class) {
Expand Down

0 comments on commit 2f5c857

Please sign in to comment.