Fix duplicate entries in generated BOM or catalog #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a dependency was managed and that it also was part of the list of modules for which version inference should be triggered, then we would end up with duplicate entries in the BOM. This commit fixes that by checking, when version inference occurs, if a library with the same GAV coordinates was already registered.
In case of nested BOM inlining, it was possible that we missed a case where an alias was already included, which lead to the _Gradle_ (not ours) warning "Duplicate entry for alias". However, we should avoid these, because we already capture duplicate entries (which may be fine in case we are actually overriding nested catalog versions).
alvarosanchez
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.