Fix: preserve new baggage values in context on key conflict #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. It'd help to add a test (or tests) to demonstrate the cases where this was failing and is now fixed. |
|
@shakuzen UTs are added to demonstrate the fix. |
amitsinha11
force-pushed
the
fix/context-baggage-overwrite
branch
from
fd233a8 to
5f388a9
Compare
|
@amitsinha11 Thank for the PR, could you please also sign-off your commits so the DCO check can pass? You can read more about it by clicking on the failing check. |
…er-metrics#1061) Signed-off-by: Amit Sinha <amit.sinha2@soprabanking.com>
amitsinha11
force-pushed
the
fix/context-baggage-overwrite
branch
from
5f388a9 to
906f93d
Compare
|
@jonatan-ivanov done, DCO check is ok now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1060