Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-configure DiskSpaceMetrics #703

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jul 5, 2018

This PR auto-configures DiskSpaceMetrics.

@izeye izeye mentioned this pull request Jul 5, 2018
@jkschneider
Copy link
Contributor

I'm going to hold off on this just temporarily until I have a chance to review what the default Netflix alerts were for disk utilization. It may lead to another disk binder that is more appropriate for autoconfiguration.

@jkschneider jkschneider added this to the 1.1.0 milestone Jul 11, 2018
@jkschneider jkschneider added the spring-boot change Change is needed in Spring Boot for this issue label Sep 20, 2018
@izeye izeye force-pushed the auto-configure-disk-space-metrics branch from 4a1f93f to ff94519 Compare October 13, 2018 04:39
@izeye
Copy link
Contributor Author

izeye commented Oct 13, 2018

I rebased onto the current master to resolve conflicts.

@jkschneider
Copy link
Contributor

Going to have to move this to 1.2.0. I still think it's likely DiskSpaceMetrics needs to be revised before 1.0 GA and we'll miss the Boot 2.1 RC cutoff for introducing additional autoconfigs.

@jkschneider jkschneider modified the milestones: 1.1.0-rc.1, 1.2.0 Oct 14, 2018
@jkschneider jkschneider modified the milestones: 1.2.0, 1.x Oct 26, 2018
@izeye
Copy link
Contributor Author

izeye commented Feb 8, 2021

Closing as the micrometer-spring-legacy module has been removed since Micrometer 1.4.0 via #1662.

@izeye izeye closed this Feb 8, 2021
@izeye izeye deleted the auto-configure-disk-space-metrics branch February 8, 2021 00:19
@jonatan-ivanov jonatan-ivanov removed this from the 1.x milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spring-boot change Change is needed in Spring Boot for this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants