Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AutoShutdownDelegatedExecutorService #4315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nscuro
Copy link

@nscuro nscuro commented Nov 4, 2023

This executor is returned by Executors#newSingleThreadExecutor under Java 21.

@pivotal-cla
Copy link

@nscuro Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@nscuro Thank you for signing the Contributor License Agreement!

This executor is returned by `Executors#newSingleThreadExecutor` under Java 21.

Signed-off-by: nscuro <nscuro@protonmail.com>
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. Would you please add tests that verify the metrics work with Executors of the new type added?

@shakuzen shakuzen added this to the 1.15.0-M1 milestone Dec 20, 2024
@shakuzen shakuzen added enhancement A general enhancement instrumentation An issue that is related to instrumenting a component labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement instrumentation An issue that is related to instrumenting a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants