[Dynatrace v2] Update to utils library v2 #4064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to dynatrace-metric-utils v2
arminru
force-pushed
the
update-util-library
branch
from
99e12cc
to
ac0c96c
Compare
jonatan-ivanov
requested changes
Sep 15, 2023
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Show resolved
Hide resolved
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Outdated
Show resolved
Hide resolved
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Outdated
Show resolved
Hide resolved
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Outdated
Show resolved
Hide resolved
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Outdated
Show resolved
Hide resolved
| @@ -493,4 +524,23 @@ private void storeMetadataLine(Metric.Builder metricBuilder, Map<String, String> | |||
| } | |||
| } | |||
|
|
|||
| private String extractMetricKey(String metadataLine) { | |||
There was a problem hiding this comment.
Can't MetadataStep do this for us instead of encoding it into a string and then trying to decode it again?
This also feels quite brittle. Btw should the index start at 1?
There was a problem hiding this comment.
Btw should the index start at 1?
Yes that's on purpose, the first index will always be #, I added a clarifying comment in 0d6d7f0
jonatan-ivanov
added
enhancement
…der before calling build() on it
…> enrichMetadataStep()
pichlermarc
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Thank you for the review. 🙂
I addressed some comments while @pirgeo is out of office
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Show resolved
Hide resolved
| @@ -493,4 +524,23 @@ private void storeMetadataLine(Metric.Builder metricBuilder, Map<String, String> | |||
| } | |||
| } | |||
|
|
|||
| private String extractMetricKey(String metadataLine) { | |||
There was a problem hiding this comment.
Btw should the index start at 1?
Yes that's on purpose, the first index will always be #, I added a clarifying comment in 0d6d7f0
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Outdated
Show resolved
Hide resolved
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Outdated
Show resolved
Hide resolved
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Outdated
Show resolved
Hide resolved
...rometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/v2/DynatraceExporterV2.java
Outdated
Show resolved
Hide resolved
jonatan-ivanov
pushed a commit
that referenced
this pull request
Sep 20, 2023
See gh-4064 Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com> Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com> Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
jonatan-ivanov
added a commit
that referenced
this pull request
Sep 20, 2023
|
I polished the PR a bit and merged it in, thank you all for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Dynatrace exporter v2 to use the new dynatrace-metric-utils library v2.0.0 which provides a big boost in performance while also reducing the memory overhead. v2 has been released on Maven central.