Use micrometer-core project dependency in micrometer-samples-boot2 #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build in my CircleCI has already finished before creating this PR, and its results didn't show up here. So I force-pushed without changes. The results seem okay now. |
shakuzen
reviewed
Mar 21, 2020
| ['atlas', 'azure-monitor', 'prometheus', 'datadog', 'elastic', 'ganglia', 'graphite', 'jmx', 'influx', 'statsd', 'new-relic', 'cloudwatch', 'cloudwatch2', 'signalfx', 'wavefront', 'elastic', 'dynatrace', 'humio', 'appoptics', 'stackdriver'].each { sys -> | ||
| implementation project(":micrometer-registry-$sys") | ||
| } | ||
|
|
||
| implementation 'org.springframework.boot:spring-boot-starter-web' | ||
| implementation 'org.springframework.boot:spring-boot-starter-actuator' | ||
| implementation('org.springframework.boot:spring-boot-starter-actuator') { | ||
| exclude group: 'io.micrometer', module: 'micrometer-core' |
There was a problem hiding this comment.
Do we need to explicitly exclude this here or does the direct declaration of implementation project(":micrometer-core") override the transitive dependency? Just curious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was looking at the build failure from #1921 (comment), I noticed that
micrometer-samples-boot2uses Spring Boot managed version ofmicrometer-coredependency whereas it uses backend implementations from the project. This PR changes to usemicrometer-coreproject dependency inmicrometer-samples-boot2.I don't know the root cause of the build failure, but this change seems to fix it.