Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow histogram buckets to be defined as doubles #1909

Closed
wants to merge 1 commit into from
Closed

Allow histogram buckets to be defined as doubles #1909

wants to merge 1 commit into from

Conversation

newffy
Copy link
Contributor

@newffy newffy commented Mar 17, 2020

Near all usages of CountAtBucket.bucket() are made from double context. This allows to make HistogramSnapshot objects for histograms with double bucket boundaries

jkschneider pushed a commit that referenced this pull request Mar 17, 2020
SLA and min/max expected values are now defined as doubles, deprecate…
3da05bb 
…d methods accepting long values (issue #1909)
@jkschneider jkschneider added this to the 1.4.0 milestone Mar 17, 2020
@jkschneider
Copy link
Contributor

Merged with 3da05bb.

@jkschneider jkschneider changed the title Allowing CountAtBucket to store doubles Histogram buckets are defined as doubles now. Mar 17, 2020
@jkschneider jkschneider changed the title Histogram buckets are defined as doubles now. Histogram buckets are defined as doubles rather than longs. Mar 17, 2020
@jkschneider
Copy link
Contributor

This change precedes additions for VictoriaMetrics sparsely populated histograms, and also better supports DistributionSummary whose base unit may not always be an integral value (e.g. temperature).

Further context around this change here: https://micrometer-metrics.slack.com/archives/C662HUJC9/p1584048617111800

@shakuzen shakuzen changed the title Histogram buckets are defined as doubles rather than longs. Allow histogram buckets defined as doubles Mar 18, 2020
@shakuzen shakuzen added the enhancement A general enhancement label Mar 18, 2020
@shakuzen shakuzen changed the title Allow histogram buckets defined as doubles Allow histogram buckets to be defined as doubles Mar 18, 2020
@izeye izeye mentioned this pull request Apr 1, 2020
Merged
@snicoll snicoll mentioned this pull request Apr 4, 2020
Closed
snicoll added a commit to snicoll/spring-boot that referenced this pull request Apr 6, 2020
@snicoll
Update SLA boundaries to use double
c9c8b94 
See micrometer-metrics/micrometer#1909

Closes spring-projectsgh-20837
snicoll added a commit to spring-projects/spring-boot that referenced this pull request Apr 6, 2020
@snicoll
Update SLA boundaries to use double
30201a4 
See micrometer-metrics/micrometer#1909

Closes gh-20837
@anuraaga anuraaga mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@newffy @jkschneider @shakuzen