Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stackdriver - Ability to configure credentials #1682

Merged
merged 4 commits into from
Jan 17, 2020
Merged

Stackdriver - Ability to configure credentials #1682

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b16de7
Ability to configure credentials
saturnism Nov 1, 2019
12e468a
realized that the public constructor was only used for testing; shoul…
saturnism Nov 2, 2019
884043d
revert protected to public
saturnism Jan 13, 2020
85dabdd
Merge remote-tracking branch 'upstream/master' into stackdriver-crede…
saturnism Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert protected to public
  • Loading branch information
@saturnism
saturnism committed Jan 13, 2020
commit 884043d1053083f914bfc142d18c6841a51dca72
2 changes: 1 addition & 1 deletion ...egistry-stackdriver/src/main/java/io/micrometer/stackdriver/StackdriverMeterRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public class StackdriverMeterRegistry extends StepMeterRegistry {
@Nullable
private MetricServiceClient client;

protected StackdriverMeterRegistry(StackdriverConfig config, Clock clock) {
public StackdriverMeterRegistry(StackdriverConfig config, Clock clock) {
this(config, clock, DEFAULT_THREAD_FACTORY, () -> MetricServiceSettings.newBuilder().build());
}

Expand Down