Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynatrace Registry: Export units and descriptions #3979

Closed
arminru opened this issue Jul 11, 2023 · 1 comment · Fixed by #4006
Closed

Dynatrace Registry: Export units and descriptions #3979

arminru opened this issue Jul 11, 2023 · 1 comment · Fixed by #4006
Assignees
@pirgeo
Labels
enhancement A general enhancement registry: dynatrace A Dynatrace Registry related issue
Milestone
1.12.0-M3

Comments

@arminru
Copy link
Contributor

arminru commented Jul 11, 2023 •
edited
Loading

Please describe the feature request
The Micrometer API allows for defining a description and baseUnit upon Meter creation.
The Dynatrace metrics ingestion API used by the Dynatrace Micrometer registry allows for specifying units and descriptions for ingested metrics: https://www.dynatrace.com/support/help/shortlink/metric-ingestion-protocol#metadata

It would be great if the Dynatrace registry would make full use of both APIs and also export the unit and description for each metric if they are specified by the user.

Rationale
The Meter description can describe a metric in more detail than just the metric name itself.
The Meter unit can help when interpreting metrics and is useful to tell whether different metrics are comparable with one another.

Additional context
https://www.dynatrace.com/support/help/shortlink/metric-ingestion-protocol#metadata
https://www.dynatrace.com/support/help/shortlink/custom-metric-metadata

cc @pirgeo
@pirgeo
Copy link
Contributor

pirgeo commented Jul 11, 2023

I am already working on this and am targeting the November release (1.12.0). I will open a PR and link to this issue as soon as I have something!

@shakuzen shakuzen added enhancement A general enhancement registry: dynatrace A Dynatrace Registry related issue and removed waiting-for-triage labels Jul 27, 2023
@shakuzen shakuzen added this to the 1.12 backlog milestone Jul 27, 2023
@pirgeo pirgeo mentioned this issue Aug 1, 2023
Merged
shakuzen pushed a commit that referenced this issue Sep 1, 2023
@pirgeo @arminru
[Dynatrace v2] Export unit/description to Dynatrace (#4006)
44c334a 
Export Meter's unit and description as Dynatrace metadata by default. This new behavior can be toggled by a new configuration method `exportMeterMetadata` on DynatraceConfig.

Resolves gh-3979

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@shakuzen shakuzen modified the milestones: 1.12 backlog, 1.12.0-M3 Sep 1, 2023
jonatan-ivanov added a commit that referenced this issue Oct 21, 2023
@pirgeo @jonatan-ivanov
Only serialize metadata when set on the meter
9df4469 
gh-4006 added support for metrics metadata (unit and description) in the
Dynatrace Exporter. The exporter always added the metadata even if unit
or description were not set. After these changes,
the exporter should not attempt to add metadata if no unit
or description was set on the metric.

See gh-4247
See gh-3979
See gh-4006

Co-authored-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirgeo pirgeo

Labels
enhancement A general enhancement registry: dynatrace A Dynatrace Registry related issue
Projects
None yet
Milestone
1.12.0-M3
Development

Successfully merging a pull request may close this issue.

[Dynatrace v2] Export unit/description to Dynatrace dynatrace-oss-contrib/micrometer
3 participants
@arminru @shakuzen @pirgeo