Skip to content

Conversation

Jason3S
Copy link
Contributor

@Jason3S Jason3S commented Apr 18, 2025

Picomatch will throw exceptions when the glob contains any Object instance property names.

Examples: constructor, __proto__, toString

Related to issue: streetsidesoftware/cspell#7194

@Jason3S
Copy link
Contributor Author

Jason3S commented Apr 18, 2025

@jonschlinkert,

Is there any way this can make it in? There is a similar fix in #132, but it is slower.

@coveralls
Copy link

Coverage Status

coverage: 91.968%. remained the same
when pulling a9e2dd2 on Jason3S:jdent-object-properties
into bf6a33b on micromatch:master.

@ngraef
Copy link

ngraef commented May 22, 2025

@jonschlinkert, could you please take a look at this when you have a moment?

I spent some time debugging an error with tsup --watch in my project and traced it back to this issue.

@Jason3S
Copy link
Contributor Author

Jason3S commented Jul 16, 2025

@jonschlinkert Thank you.

@Rrj115811
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants