-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token output missing in picomatch.parse
from logical or with empty element
#125
Comments
connor4312
added a commit
to connor4312/picomatch
that referenced
this issue
Dec 12, 2023
Previously sibling `text` tokens would exclude the `output` from the first token, resulting in the referenced issues. I think this should be a fairly safe change. Fixes micromatch#125 Fixes micromatch#100
connor4312
added a commit
to connor4312/picomatch
that referenced
this issue
Dec 13, 2023
Previously sibling `text` tokens would exclude the `output` from the first token, resulting in the referenced issues. I think this should be a fairly safe change. Fixes micromatch#125 Fixes micromatch#100
connor4312
added a commit
to microsoft/vscode-js-debug
that referenced
this issue
Dec 13, 2023
Fixes microsoft/vscode#200665 Requires use of my picomatch fork due to micromatch/picomatch#125. We could alternatively use brace expansion until that's fixed, but that's much less efficient that using a logical or.
connor4312
added a commit
to microsoft/vscode-js-debug
that referenced
this issue
Dec 13, 2023
Fixes microsoft/vscode#200665 Requires use of my picomatch fork due to micromatch/picomatch#125. We could alternatively use brace expansion until that's fixed, but that's much less efficient that using a logical or.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
require('picomatch').parse('foo.(c|m|)js')
output
for the text token ofc|m|
is actually|m|
If the logical expression is modified to remove the empty element, for example making it
c|m|x
, the the problem disappears.The text was updated successfully, but these errors were encountered: