Reapply "fs/9p: Refresh metadata in d_revalidate for uncached mode too" #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micromaomao
force-pushed
the
9pfs-d-revalidate-v2
branch
from
dd1473e to
bd0be5c
Compare
This reverts commit 43c36a5. Patch was previously reverted due to overlooking cache=mmap mode. When cache=mmap (i.e. just CACHE_WRITEBACK), us refreshing the metadata lead to overriding i_size even when there was cached data to be written, effectively losing that data. This can be fixed using V9FS_STAT2INODE_KEEP_ISIZE appropriately. A case which already does this is when creating a link on a cache=loose filesystem fails on the remote side: v9fs_vfs_link() calls v9fs_refresh_inode() with this flag. Another problematic case is on a cache=6 (CACHE_META+CACHE_WRITEBACK) fs, in which we will refresh the dentry with new metadata in __v9fs_lookup_revalidate(), but does not pass V9FS_STAT2INODE_KEEP_ISIZE flag to v9fs_stat2inode(). This also fixes that.
micromaomao
force-pushed
the
9pfs-d-revalidate-v2
branch
from
bd0be5c to
b05b6af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.