Add star-rating.js #974
Merged
Add star-rating.js #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pineapplemachine
requested changes
Aug 13, 2018
There was a problem hiding this comment.
The source attribute for star-rating should be an array containing paths to both the JavaScript and the needed css. (ctrl+f "source": [ for prior examples in the data.json file.) Can you make this change? If you do that, it looks like this should be good to go.
data.js
Outdated
| tags: ["rating", "stars", "star-rating"], | ||
| description: "Transforms a SELECT element into a dynamic star rating control", | ||
| url: "https://geminilabs.github.io/star-rating.js/", | ||
| source: "https://raw.githubusercontent.com/geminilabs/star-rating.js/master/src/star-rating.js" |
There was a problem hiding this comment.
Should be an array of paths for both the needed JS and CSS.
pineapplemachine
approved these changes
Aug 14, 2018
|
The data.json entry looks good now. Thank you for contributing! |
pineapplemachine
added a commit
to pineapplemachine/microjs.com
that referenced
this pull request
Feb 7, 2019
* make-7-feb-2019: Rebuild atom.xml and data-min.js Fix the build script progress bar Add gradstop Add easyrouter Add ShadowQuery Added Wirup, WirupExpress to the list. Updating info on lcavadas/Storage.js Change spck-embed source. Added tutorial.js library. add spck-embed.js Added vanilla-picker-mini.js Add Beedle to the list sanitize-xml.js js2txt.js format-xml.js Fix source location of DOMtastic (microjs#976) Add star-rating.js (microjs#974) Add almy.js (microjs#975) Add Excellent.js adding Holen js # Conflicts: # lib/logger.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.