Repository navigation
DroidGuard: fix version offset for first build variant - #3816
Open
paulcakeface wants to merge 1 commit into
Open
paulcakeface wants to merge 1 commit into
paulcakeface wants to merge 1 commit into
Conversation
woahwhattheheck
added a commit
to woahwhattheheck/GmsCore
that referenced
this pull request
Oct 4, 2026
Port the production fix from microg#3816 by @paulcakeface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
VersionUtil.getVersionOffset()rejecting valid build-map entries when the third component is the first item in its list.indexOf()returns0for that first valid entry, but the existing third-index check required> 0. The two preceding index checks already correctly accept zero. This changes the third check to>= 0and adds regression coverage for valid first-entry variants plus an unknown-entry control.Validation
Base: current upstream
masterat4c74e5acb79479004428be755547432294639878.acceptsFirstDpiEntryfails becausegetVersionOffset("000300")returnsnull.:play-services-droidguard-core:testDebugUnitTest: PASS.:play-services-droidguard-core:testReleaseUnitTest: PASS.:play-services-droidguard-core:lintRelease: PASS.:play-services-core:assembleMapboxDefaultRelease: PASS (BUILD SUCCESSFUL in 13m 1s, 3241 tasks).This is a pure build-map calculation fix; no device behaviour or protocol path is changed.