Repository navigation
Maps: Redact API credentials from debug logging - #3814
Open
paulcakeface wants to merge 1 commit into
Open
paulcakeface wants to merge 1 commit into
paulcakeface wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid logging credential-bearing request and response values in the Maps
ApiTokenService.requestApiTokencurrently logs the complete incoming parameterBundle. This bundle contains theAPI_KEYvalue used to construct the Maps API token request.On a successful request, the service also logs the complete
CreateAndroidApiTokenResponse, which contains the returnedapiToken.This change replaces those value-bearing logs with bounded diagnostic messages while retaining the request-stage and success information useful for debugging.
Changes
requestApiTokenparameter bundleThere are no changes to API key handling, token request construction, returned token data, expiry handling, error handling or control flow.
Validation
The branch is based directly on current upstream
master:4c74e5acb79479004428be755547432294639878Exact validated commit:
2a30619cb257b6f61cb5cf321bb96bfc5b67ea63GitHub Actions validation completed successfully:
git diff --checkalso passes.The resulting commit changes one source file with two additions and two deletions.
No physical-device testing was required or performed because this change only alters diagnostic logging.