Remove duplicate vals

microcosm-cc · Dec 30, 2021 · 6e7247e · 6e7247e
1 parent 1eebb57
commit 6e7247e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/sanitize.go b/sanitize.go
@@ -815,9 +815,13 @@ attrsLoop:
 			if htmlAttr.Key == "sandbox" {
 				sandboxFound = true
 				var cleanVals []string
+				cleanValsSet := make(map[string]bool)
 				for _, val := range strings.Fields(htmlAttr.Val) {
 					if p.requireSandboxOnIFrame[val] {
-						cleanVals = append(cleanVals, val)
+						if !cleanValsSet[val] {
+							cleanVals = append(cleanVals, val)
+							cleanValsSet[val] = true
+						}
 					}
 				}
 				cleanAttrs[i].Val = strings.Join(cleanVals, " ")

diff --git a/sanitize_test.go b/sanitize_test.go
@@ -1876,7 +1876,7 @@ func TestIFrameSandbox(t *testing.T) {
 	p.AllowAttrs("sandbox").OnElements("iframe")
 	p.RequireSandboxOnIFrame(SandboxAllowDownloads)
 
-	in := `<iframe src="http://example.com" sandbox="allow-forms allow-downloads"></iframe>`
+	in := `<iframe src="http://example.com" sandbox="allow-forms allow-downloads allow-downloads"></iframe>`
 	expected := `<iframe sandbox="allow-downloads"></iframe>`
 	out := p.Sanitize(in)
 	if out != expected {