Handle bluetooth connection error scenarios #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
…status and what they mean.
microbit-grace
commented
Jul 26, 2024
microbit-grace
commented
Jul 26, 2024
…viceConnectionStatus instead of introducing ConnectionStatus.ChoosingDevice
microbit-grace
commented
Jul 29, 2024
microbit-grace
changed the title
…correct dialog and fix connect vs reconnect btn state
microbit-grace
commented
Jul 29, 2024
Comment on lines
+173
to
+177
| // TODO: Remove forced set status and listen to status event | ||
| // from connection library instead for radio | ||
| if (this.stage.connType === "radio") { | ||
| this.setStatus(ConnectionStatus.Connected); | ||
| } |
There was a problem hiding this comment.
Temporary workaround so that radio bridge connection happy flow still works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://microbit-global.monday.com/boards/1125389526/pulses/1575489047