Fix Safari AudioContext initialisation #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current version seem to require the user interaction to be on the stack when creating the context. Switch to a single context and resume it if it starts suspended. Add some clean-up so we can keep the single context for the lifetime of the app (across stop/start).
|
Preview build will be at |
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
microbit-robert
approved these changes
Feb 6, 2023
|
This is working well on Mac and iPadOS. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current versions seem to require the user interaction to be on the stack when creating the context.
Switch to a single context and resume it if it starts suspended.
Add some clean-up so we can keep the single context for the lifetime of the app (across stop/start).