More robust radio bridge connection #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only reconnect serial session on tab change if consumer is already listening.
microbit-robert
commented
Jul 25, 2024
Comment on lines
+152
to
+153
| if (--this.addedListeners[type] <= 0) { | ||
| this.addedListeners[type] = 0; |
There was a problem hiding this comment.
We could better manage our own callers as well. Continually clicking disconnect got us into negative numbers.
Comment on lines
+104
to
+106
| if (this.disconnectPromise) { | ||
| await this.disconnectPromise; | ||
| } |
There was a problem hiding this comment.
As discussed I'll replace this with a generic async state change queue.
microbit-matt-hillsdon
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only reconnect serial session on tab change if consumer is already listening.