Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mergeRows/mergeCols #392

Closed
antagomir opened this issue Jul 18, 2023 · 2 comments
Closed

Deprecate mergeRows/mergeCols #392

antagomir opened this issue Jul 18, 2023 · 2 comments
Assignees

Comments

@antagomir
Copy link
Member

antagomir commented Jul 18, 2023

Add an alias as follows

  • mergeRows -> mergeFeatures
  • mergeCols -> mergeSamples

For an example on how to do this, check a similar case for instance in getTopTaxa vs. getTopFeatures.

Deprecate mergeRows/mergeCols with a warning that they have been replaced with another name. See other deprecated functions for an example on how to deprecate an argument name.

Also remember to update manpage examples, vignettes, unit tests in ./tests/

Open an issue to OMA to make corresponding changes there after merging this.

@antagomir
Copy link
Member Author

Suggesting to add some more renaming in this PR as follows:

  • mergeCols -> mergeSamples
  • mergeRows -> mergeFeatures
  • agglomerateByRank -> mergeFeaturesByRank (logical to use similar naming in both functions)
  • agglomerateByPrevalence -> mergeFeaturesByPrevalence (same logic)

Some background discussion in #389

Daenarys8 added a commit to Daenarys8/mia that referenced this issue Jul 25, 2023
Signed-off-by: Daenarys8 <rysdaena8@gmail.com>
Daenarys8 added a commit to Daenarys8/mia that referenced this issue Jul 25, 2023
Signed-off-by: Daenarys8 <rysdaena8@gmail.com>
Daenarys8 added a commit to Daenarys8/mia that referenced this issue Jul 25, 2023
Signed-off-by: Daenarys8 <rysdaena8@gmail.com>
antagomir pushed a commit that referenced this issue Jul 26, 2023
@TuomasBorman
Copy link
Contributor

This is done I believe @ake123 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants